-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade actix-web #4268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! We only need to make sure all the existing tests pass. Let's run nayduck: https://github.com/near/nearcore/blob/master/nightly/nayduck.py
Just sign up on the nayduck website and run python nightly/nayduck.py
(and post the link to the build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frol why do we want to upgrade to some beta version? Is it better to wait for a stable release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) yes, only not sure if we want to use beta? Agree with @bowenwang1996.
NayDuck link: http://nayduck.eastus.cloudapp.azure.com:3000/#/run/1572 |
@bowenwang1996 we are already on actix betas (that was to migrate to tokio 1.x). This upgrade needed to acquire some new configuration options of awc (actix client), such as configurable size of payload to fix jsonrpc-client, and potentially resolve telemetry issue. |
Fixes #4240
actix-web
to latest betav4.0.0-beta.6
awc
directly instead of previously re-exportedactix_web::client
near/actix-extras
and updatedactix-web
dependency on all crates (actix/actix-extras@master...near:actix-web-4-beta.6)actix-http
(remove cookie support from -http actix/actix-web#2065)paperclip
and updatedactix-web
, adding and defaulting to theactix4
feature flag (near/paperclip@b9589c6)